togglebutton: Don't crash on click
authorMatthias Clasen <mclasen@redhat.com>
Sun, 2 Aug 2020 00:09:05 +0000 (20:09 -0400)
committerMatthias Clasen <mclasen@redhat.com>
Sun, 2 Aug 2020 00:09:05 +0000 (20:09 -0400)
The code used to do
if (parent_class->clicked)
  parent_class->clicked (...)
That is pointless because the parent_class never changes,
so there' no need for that if and commit 415946eb0f3b76ba25
took it out. Unfortunately, p arent_class->clicked is NULL
though, so the whole call needs to go.

gtk/gtktogglebutton.c

index 343efdb59346734bde9dea01a5a4d941f743be95..66c65f9a6e0d49fdce3d61e6863895305b949e4f 100644 (file)
@@ -185,8 +185,6 @@ gtk_toggle_button_clicked (GtkButton *button)
   GtkToggleButtonPrivate *priv = gtk_toggle_button_get_instance_private (toggle_button);
 
   gtk_toggle_button_set_active (toggle_button, !priv->active);
-
-  GTK_BUTTON_CLASS (gtk_toggle_button_parent_class)->clicked (button);
 }
 
 static void